#13555 - Fix editing Notifier in phone DD#13590
Merged
Merged
Conversation
- Restored previous query for retrieving notifier - Changed the edit form to only edit the current version of the notifier
|
Caution Review failedThe pull request is closed. WalkthroughBackend: Rewrote NotifierService.getByUuidAndTime SQL from UNION-based selection to a LEFT JOIN with COALESCE over notifier and latest matching notifier_history row. UI: CaseNotifierSideViewController.editNotifier now fetches NotifierDto by current uuid instead of time-based retrieval. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User
participant UI as CaseNotifierSideViewController
participant Backend as NotifierService
participant DB as DB (notifier, notifier_history)
User->>UI: Edit Notifier
Note over UI: Load Notifier for editing
UI->>Backend: getByUuid(uuid) (New)
rect rgba(230,245,255,0.5)
Backend->>DB: SELECT from notifier WHERE uuid=?
DB-->>Backend: Current notifier row
end
Backend-->>UI: NotifierDto (current)
Note over UI,Backend: Previously: getByUuidAndTime(uuid, versionDate)
rect rgba(255,240,230,0.5)
UI->>Backend: getByUuidAndTime(uuid, t) (Old)
Backend->>DB: SELECT via LEFT JOIN on latest history <= t with COALESCE
DB-->>Backend: Reconstructed time-sliced row
Backend-->>UI: NotifierDto (as of t)
end
UI-->>User: Open edit form with current data
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (2)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
KarnaiahPesula
approved these changes
Sep 3, 2025
Contributor
|
SonarCloud analysis: https://sonarcloud.io/dashboard?id=SORMAS-Project&pullRequest=13590 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Bug Fixes
Refactor